Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename prices -> exchange rates #1351

Merged
merged 4 commits into from
Apr 21, 2023
Merged

refactor: rename prices -> exchange rates #1351

merged 4 commits into from
Apr 21, 2023

Conversation

sabineschaller
Copy link
Member

@sabineschaller sabineschaller commented Apr 19, 2023 •
edited
Loading

Changes proposed in this pull request

  • rename prices -> exchange rates because the prices term was confusing
  • add OpenAPI spec for exchange rates

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related labels Apr 19, 2023
@sabineschaller sabineschaller changed the title S2 exchange rates refactor: rename prices -> exchange rates Apr 19, 2023
@sabineschaller sabineschaller marked this pull request as ready for review April 19, 2023 11:31
@sabineschaller sabineschaller requested a review from mkurapov April 19, 2023 11:31
mkurapov
mkurapov reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

mkurapov
mkurapov reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the MASE change, otherwise LGTM

@sabineschaller sabineschaller merged commit e463e10 into main Apr 21, 2023
@sabineschaller sabineschaller deleted the s2-exchange-rates branch April 21, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa left review comments

@mkurapov mkurapov mkurapov approved these changes

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabineschaller @mkurapov @raducristianpopa