Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate backend <> account provider requests #626

Closed
wilsonianb opened this issue Sep 21, 2022 · 4 comments
Closed

Validate backend <> account provider requests #626

wilsonianb opened this issue Sep 21, 2022 · 4 comments
Assignees
@sabineschaller
Labels
pkg: backend Changes in the backend package. type: enhancement New feature or request
Milestone
Tech Debt

Comments

@wilsonianb
Copy link
Contributor

wilsonianb commented Sep 21, 2022 •
edited by sabineschaller
Loading

Write OpenAPI spec for quote request, prices request, and webhook events, to allow the backend and account provider to validate requests and responses.

See: integration docs

Graphql already handles admin api validation.
@wilsonianb wilsonianb added the pkg: backend Changes in the backend package. label Sep 21, 2022
@wilsonianb
Copy link
Contributor Author

@wilsonianb wilsonianb mentioned this issue Oct 3, 2022
Closed
@sabineschaller sabineschaller added the type: enhancement New feature or request label Dec 12, 2022
@sabineschaller
Copy link
Member

Webhooks spec was added with

@sabineschaller sabineschaller added this to the Tech Debt milestone Mar 29, 2023
@sabineschaller sabineschaller self-assigned this Apr 11, 2023
@sabineschaller sabineschaller mentioned this issue Apr 19, 2023
Merged
4 tasks
@sabineschaller
Copy link
Member

Prices (exchange rates) request responses are already validated:

https://github.com/interledger/rafiki/blob/main/packages/backend/src/rates/service.ts#L115

@mkurapov mkurapov added this to Rafiki Jun 21, 2023
@mkurapov mkurapov moved this to Backlog in Rafiki Jun 21, 2023
@mkurapov
Copy link
Contributor

mkurapov commented Mar 4, 2024

  • Quote route no longer exists
  • We have a webhook OpenAPI spec, but no need to validate the request itself
  • We validate rate response in route

@mkurapov mkurapov closed this as completed Mar 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Rafiki Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sabineschaller sabineschaller

Labels
pkg: backend Changes in the backend package. type: enhancement New feature or request
Projects
Rafiki
Archived in project
Rafiki
Status: No status
Milestone
Tech Debt
Development

No branches or pull requests
3 participants
@wilsonianb @mkurapov @sabineschaller