Remove Unnecessary --privileged Flag While Keeping It for WSL Users #12920
+2
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the issue: #12792, we need to remove
--privileged
whenever possible.Through testing, we found that when launching the
serving-xpu
image on Linux, using--device=/dev/dri --group-add video
can replace--device=/dev/dri --privileged
. By adding the container user to thevideo
group, it can access the/dev/dri
device. Both offline inference and benchmarking work fine under this configuration.However, on WSL + Docker,
--privileged
is still required; otherwise, the GPU cannot be accessed.1. Why the change?
--privileged
usage.--privileged
for Windows WSL users, as it is still required in that case.2. User API changes
3. Summary of the change
4. How to test?
1234
). And paste your action link here once it has been successfully finished.5. New dependencies
- Dependency1
- Dependency2
- ...
- Dependency1 and license1
- Dependency2 and license2
- ...