Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Removing remaining privileged container flags #12792

Closed
charliez0 opened this issue Feb 9, 2025 · 3 comments
Closed

[Security] Removing remaining privileged container flags #12792

charliez0 opened this issue Feb 9, 2025 · 3 comments
Assignees

Comments

@charliez0
Copy link

Following the successful removal of privileged containers in #8432, we noticed some privileged usage still exists in the codebase (search results).

Would you consider:

  1. Comprehensive audit to remove all privileged flags
  2. Using granular capabilities instead where needed

This would align with container security best practices and build on the great work already done in #8432.

@liu-shaojun
Copy link
Contributor

Thanks for bringing this up! We'll go through the codebase to identify any unnecessary --privileged usage and remove it. Where needed, we'll replace it with more granular capabilities to align with container security best practices. Appreciate the suggestion!

@charliez0
Copy link
Author

any progresses?

@liu-shaojun
Copy link
Contributor

Hi @charliez0

We've submitted a PR to remove the unnecessary --privileged flag on Linux. However, in the Windows + WSL scenario, --privileged is still required for GPU access, so we've kept it for now.

Let us know if you have any further concerns!

Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants