This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add JQ input field that accepts any type #201
Merged
donch1989
merged 1 commit into
main
from
jvalles/ins-5232-component-accept-any-type-not-a-json-string-in-jq-operator
Jul 15, 2024
Merged
feat: add JQ input field that accepts any type #201
donch1989
merged 1 commit into
main
from
jvalles/ins-5232-component-accept-any-type-not-a-json-string-in-jq-operator
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task took only strings, which forced users to pre-process objects with another JSON operator that marshalled the input.
jvallesm
force-pushed
the
jvalles/ins-5232-component-accept-any-type-not-a-json-string-in-jq-operator
branch
from
July 11, 2024 15:14
c346ea3
to
19ed60c
Compare
jvallesm
changed the title
feat(wip): add JQ input field that accepts any type
feat: add JQ input field that accepts any type
Jul 11, 2024
jvallesm
requested review from
GeorgeWilliamStrong,
donch1989,
pinglin and
xiaofei-du
as code owners
July 11, 2024 15:28
donch1989
deleted the
jvalles/ins-5232-component-accept-any-type-not-a-json-string-in-jq-operator
branch
July 15, 2024 01:36
Looks great - thanks @jvallesm. Sorry, I didn't have time to review this until just now 🫠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
donch1989
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.22.0-beta](v0.21.0-beta...v0.22.0-beta) (2024-07-16) ### Features * add GitHub component ([#177](#177)) ([46e5a8e](46e5a8e)) * add JQ input field that accepts any type ([#201](#201)) ([cba4aac](cba4aac)) * **cohere:** add Cohere component ([#187](#187)) ([63fd578](63fd578)) * **cohere:** add cohere to be able to use instill credit ([#213](#213)) ([80415b1](80415b1)) * GitHub component pagination ([#212](#212)) ([4b8bbc7](4b8bbc7)) * **instill:** send requester UID, if present, on model trigger ([#202](#202)) ([31422cd](31422cd)) * **mistral:** add Mistral AI component ([#204](#204)) ([12aaf4f](12aaf4f)) * **openai:** add dimensions in openai component ([#200](#200)) ([0d08912](0d08912)) * **text:** add input and output and fix bugs ([#209](#209)) ([56ab3eb](56ab3eb)) * unify pipeline and component usage handlers ([#197](#197)) ([e27e46c](e27e46c)) ### Bug Fixes * fix instillUpstreamTypes not correctly render the JSON schema ([#216](#216)) ([bb603bd](bb603bd)) * **mistralai:** svg naming is wrong ([#218](#218)) ([108817a](108817a)) * **text:** hotfix the bug from langchaingo without importing the function o… ([#217](#217)) ([4cfc263](4cfc263)) * typo ([#195](#195)) ([d6b2a42](d6b2a42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
jq
task took only strings, which can be leveraged for reference but forced users to pre-process objects with another JSON operator that marshalled the input.This commit