Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

feat(openai): add dimensions in openai component #200

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

chuang8511
Copy link
Contributor

Because

  • in many use cases, users may not need to output vectors of such high dimensionality and might only require the first 'x' dimensions.

This commit

  • add dimensions in api caller

@chuang8511
Copy link
Contributor Author

Will need to do end to end test before converting to Open

@chuang8511
Copy link
Contributor Author

Tested
image

@chuang8511 chuang8511 marked this pull request as ready for review July 5, 2024 17:50
@donch1989
Copy link
Member

@chuang8511
Can you confirm it still works if we don't set the dimension and leave it empty?

@chuang8511
Copy link
Contributor Author

@donch1989
Thanks for pointing this. I missed it.
I did not find the official document for the default dimensions.
So, I did not set it by default but keep the original ways.

E2E test
image
image

Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
By the way, please use feat(component-id): xxx for the PR title next time.
For example:
From feat: add dimensions in openai component to feat(openai): add dimensions in openai component.

@donch1989 donch1989 changed the title feat: add dimensions in openai component feat(openai): add dimensions in openai component Jul 8, 2024
@donch1989 donch1989 merged commit 0d08912 into main Jul 8, 2024
9 checks passed
@donch1989 donch1989 deleted the chunhao/ins-5153 branch July 8, 2024 13:25
AmeliaCelline pushed a commit to AmeliaCelline/fork-component that referenced this pull request Jul 15, 2024
Because

- in many use cases, users may not need to output vectors of such high
dimensionality and might only require the first 'x' dimensions.

This commit

- add dimensions in api caller
donch1989 pushed a commit that referenced this pull request Jul 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-beta](v0.21.0-beta...v0.22.0-beta)
(2024-07-16)


### Features

* add GitHub component
([#177](#177))
([46e5a8e](46e5a8e))
* add JQ input field that accepts any type
([#201](#201))
([cba4aac](cba4aac))
* **cohere:** add Cohere component
([#187](#187))
([63fd578](63fd578))
* **cohere:** add cohere to be able to use instill credit
([#213](#213))
([80415b1](80415b1))
* GitHub component pagination
([#212](#212))
([4b8bbc7](4b8bbc7))
* **instill:** send requester UID, if present, on model trigger
([#202](#202))
([31422cd](31422cd))
* **mistral:** add Mistral AI component
([#204](#204))
([12aaf4f](12aaf4f))
* **openai:** add dimensions in openai component
([#200](#200))
([0d08912](0d08912))
* **text:** add input and output and fix bugs
([#209](#209))
([56ab3eb](56ab3eb))
* unify pipeline and component usage handlers
([#197](#197))
([e27e46c](e27e46c))


### Bug Fixes

* fix instillUpstreamTypes not correctly render the JSON schema
([#216](#216))
([bb603bd](bb603bd))
* **mistralai:** svg naming is wrong
([#218](#218))
([108817a](108817a))
* **text:** hotfix the bug from langchaingo without importing the
function o… ([#217](#217))
([4cfc263](4cfc263))
* typo ([#195](#195))
([d6b2a42](d6b2a42))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

3 participants