Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

feat: use kebab-case for all component input and output properties #164

Merged
merged 9 commits into from
Jun 14, 2024
Merged

feat: use kebab-case for all component input and output properties #164

merged 9 commits into from
Jun 14, 2024

Conversation

donch1989
Copy link
Member

Because

  • We'd like to standardize the variable naming convention in the pipeline recipe, including component ID, component input, output, and setup properties.

This commit

  • Updates all component input, output, and setup properties to use kebab-case.

@linear Linear
Copy link

linear bot commented Jun 14, 2024

INS-4452 change all component properties to use kebab-case

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 14, 2024
View reviewed changes
ai/openai/v0/main.go Dismissed Show dismissed Hide dismissed
ai/stabilityai/v0/main.go Dismissed Show dismissed Hide dismissed
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.31008% with 77 lines in your changes missing coverage. Please review.

Project coverage is 36.21%. Comparing base (4ce9851) to head (24a91ab).
Report is 65 commits behind head on main.

❗ Current head 24a91ab differs from pull request most recent head f3c2e42

Please upload reports for the commit f3c2e42 to get more accurate results.

Files Patch % Lines
base/component.go 27.27% 32 Missing ⚠️
ai/instill/v0/llm_utils.go 0.00% 13 Missing ⚠️
data/googlecloudstorage/v0/main.go 0.00% 7 Missing ⚠️
ai/instill/v0/image_to_image.go 0.00% 6 Missing ⚠️
ai/instill/v0/text_to_image.go 0.00% 4 Missing ⚠️
data/bigquery/v0/main.go 0.00% 4 Missing ⚠️
ai/huggingface/v0/main.go 90.00% 0 Missing and 2 partials ⚠️
ai/instill/v0/main.go 0.00% 2 Missing ⚠️
application/googlesearch/v0/main.go 0.00% 2 Missing ⚠️
application/restapi/v0/main.go 33.33% 2 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #164       +/-   ##
===========================================
- Coverage   57.32%   36.21%   -21.12%     
===========================================
  Files          30       69       +39     
  Lines        3145     6826     +3681     
===========================================
+ Hits         1803     2472      +669     
- Misses       1104     3997     +2893     
- Partials      238      357      +119
Flag Coverage Δ
unittests 36.21% <40.31%> (-21.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 force-pushed the huitang/ins-4452-2 branch from 24a91ab to 229113c Compare June 14, 2024 17:43
@donch1989 donch1989 merged commit 4a82be7 into main Jun 14, 2024
9 checks passed
@donch1989 donch1989 deleted the huitang/ins-4452-2 branch June 14, 2024 18:02
@droplet-bot droplet-bot mentioned this pull request Jun 14, 2024
Merged
donch1989 pushed a commit that referenced this pull request Jun 19, 2024
@droplet-bot
chore(main): release 0.20.0-beta (#163)
c632862 
🤖 I have created a release *beep* *boop*
---


##
[0.20.0-beta](v0.19.1-beta...v0.20.0-beta)
(2024-06-18)


### Features

* add toggle image tag function for document pdf to markdown task
([#162](#162))
([f12ecd2](f12ecd2))
* use camelCase in JSON files
([#158](#158))
([ecf4dd9](ecf4dd9))
* use kebab-case for all component input and output properties
([#164](#164))
([4a82be7](4a82be7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
@donch1989
feat: use kebab-case for all component input and output properties (i…
297e456 
…nstill-ai#164)

Because

- We'd like to standardize the variable naming convention in the
pipeline recipe, including component ID, component input, output, and
setup properties.

This commit

- Updates all component input, output, and setup properties to use
kebab-case.
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
@donch1989 @namwoam
feat: use kebab-case for all component input and output properties (i…
a6b6c22 
…nstill-ai#164)

Because

- We'd like to standardize the variable naming convention in the
pipeline recipe, including component ID, component input, output, and
setup properties.

This commit

- Updates all component input, output, and setup properties to use
kebab-case.
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
@droplet-bot @namwoam
chore(main): release 0.20.0-beta (instill-ai#163)
5e42da1 
🤖 I have created a release *beep* *boop*
---


##
[0.20.0-beta](instill-ai/component@v0.19.1-beta...v0.20.0-beta)
(2024-06-18)


### Features

* add toggle image tag function for document pdf to markdown task
([instill-ai#162](instill-ai#162))
([f12ecd2](instill-ai@f12ecd2))
* use camelCase in JSON files
([instill-ai#158](instill-ai#158))
([ecf4dd9](instill-ai@ecf4dd9))
* use kebab-case for all component input and output properties
([instill-ai#164](instill-ai#164))
([4a82be7](instill-ai@4a82be7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
@droplet-bot @namwoam
chore(main): release 0.20.0-beta (instill-ai#163)
35fff53 
🤖 I have created a release *beep* *boop*
---


##
[0.20.0-beta](instill-ai/component@v0.19.1-beta...v0.20.0-beta)
(2024-06-18)


### Features

* add toggle image tag function for document pdf to markdown task
([instill-ai#162](instill-ai#162))
([f12ecd2](instill-ai@f12ecd2))
* use camelCase in JSON files
([instill-ai#158](instill-ai#158))
([ecf4dd9](instill-ai@ecf4dd9))
* use kebab-case for all component input and output properties
([instill-ai#164](instill-ai#164))
([4a82be7](instill-ai@4a82be7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

Assignees
No one assigned
Labels
instill component
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donch1989 @droplet-bot