This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
feat: use camelCase in JSON files #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8742445 to
9b35859
Compare
9b35859 to
46da421
Compare
donch1989
pushed a commit
that referenced
this pull request
Jun 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.20.0-beta](v0.19.1-beta...v0.20.0-beta) (2024-06-18) ### Features * add toggle image tag function for document pdf to markdown task ([#162](#162)) ([f12ecd2](f12ecd2)) * use camelCase in JSON files ([#158](#158)) ([ecf4dd9](ecf4dd9)) * use kebab-case for all component input and output properties ([#164](#164)) ([4a82be7](4a82be7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
Because: - Currently, our JSON files are a mix of camelCase, snake_case, and kebab-case, which is not consistent. This commit: - Uses camelCase in JSON files. - Simplify `ComponentConfig` struct since most of the fields are not used in the component package. Note: - We don't change the JSON keys of `properties` in this PR. We'll use kebab-case for them and address this in another PR.
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
Because: - Currently, our JSON files are a mix of camelCase, snake_case, and kebab-case, which is not consistent. This commit: - Uses camelCase in JSON files. - Simplify `ComponentConfig` struct since most of the fields are not used in the component package. Note: - We don't change the JSON keys of `properties` in this PR. We'll use kebab-case for them and address this in another PR.
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.20.0-beta](instill-ai/component@v0.19.1-beta...v0.20.0-beta) (2024-06-18) ### Features * add toggle image tag function for document pdf to markdown task ([instill-ai#162](instill-ai#162)) ([f12ecd2](instill-ai@f12ecd2)) * use camelCase in JSON files ([instill-ai#158](instill-ai#158)) ([ecf4dd9](instill-ai@ecf4dd9)) * use kebab-case for all component input and output properties ([instill-ai#164](instill-ai#164)) ([4a82be7](instill-ai@4a82be7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
Because: - Currently, our JSON files are a mix of camelCase, snake_case, and kebab-case, which is not consistent. This commit: - Uses camelCase in JSON files. - Simplify `ComponentConfig` struct since most of the fields are not used in the component package. Note: - We don't change the JSON keys of `properties` in this PR. We'll use kebab-case for them and address this in another PR.
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.20.0-beta](instill-ai/component@v0.19.1-beta...v0.20.0-beta) (2024-06-18) ### Features * add toggle image tag function for document pdf to markdown task ([instill-ai#162](instill-ai#162)) ([f12ecd2](instill-ai@f12ecd2)) * use camelCase in JSON files ([instill-ai#158](instill-ai#158)) ([ecf4dd9](instill-ai@ecf4dd9)) * use kebab-case for all component input and output properties ([instill-ai#164](instill-ai#164)) ([4a82be7](instill-ai@4a82be7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
ComponentConfigstruct since most of the fields are not used in the component package.Note:
propertiesin this PR. We'll use kebab-case for them and address this in another PR.