Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource scheduler: agent instrumentation #8010

Closed
5 of 8 tasks
sanderr opened this issue Aug 27, 2024 · 0 comments
Closed
5 of 8 tasks

resource scheduler: agent instrumentation #8010

sanderr opened this issue Aug 27, 2024 · 0 comments
Assignees

Comments

@sanderr
Copy link
Contributor

sanderr commented Aug 27, 2024

Implement the interaction between scheduler and agent. Make sure the scheduler can drive the agent on a per-resource basis. Make sure the old mode still works when the config option (part of #8009) is set.

  • start scheduler on the agent if the new mode is selected

  • implement Scheduler._run_task to request an executor and to delegate the resource action request to it, focus on deploy only

  • add test with dummy executor

  • clean up

    • collect discussion points in slides?
  • merge PR 1

  • look into state representation and propagation

  • test DB state Vs scheduler state

  • process failures appropriately

#7561 already contains parts of this, though it was created before the resource scheduler design, it may or may not be easier to just start from scratch

@wouterdb wouterdb self-assigned this Aug 29, 2024
inmantaci pushed a commit that referenced this issue Sep 11, 2024
# Description

Added basic integration of scheduler and agent

This is not quite the entire ticket, but I merge it to avoid merge hell

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants