Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource scheduler: integrate with server #8009

Closed
3 tasks done
sanderr opened this issue Aug 27, 2024 · 0 comments
Closed
3 tasks done

resource scheduler: integrate with server #8009

sanderr opened this issue Aug 27, 2024 · 0 comments
Assignees
@hlloreda

Comments

@sanderr
Copy link
Contributor

sanderr commented Aug 27, 2024 •
edited by hlloreda
Loading

Integrate the scheduler with the server and the DB. Make sure there is a way (similar to the executor mode) to enable the new scheduler. Add tests where applicable, but since the agent interface is not there yet end-to-end tests are not feasible yet.

  • read initial state from the database
  • read state when new_version is called
  • add config option and integrate in release + deploy flows over the agent RPC (scheduler will live in the inmanta.agent.Agent process)

#7561 may already contain parts of this, though it was created before the resource scheduler design
@sanderr sanderr mentioned this issue Aug 27, 2024
Closed
8 tasks
@hlloreda hlloreda self-assigned this Aug 30, 2024
@sanderr sanderr mentioned this issue Aug 30, 2024
Closed
9 tasks
@hlloreda hlloreda mentioned this issue Sep 4, 2024
Closed
9 tasks
Hugo-Inmanta added a commit that referenced this issue Sep 9, 2024
@Hugo-Inmanta
Revert "Integrate scheduler with server (Issue #8009, PR #8050)"
a0b6d70 
This reverts commit 0ad385c.
wouterdb added a commit that referenced this issue Sep 9, 2024
@wouterdb
Revert "Integrate scheduler with server (Issue #8009, PR #8050)"
8b49f0d 
This reverts commit 0ad385c.
inmantaci pushed a commit that referenced this issue Sep 9, 2024
@sanderr @inmantaci
Integrate scheduler with server (Issue #8009, PR #8050)
22eab72 
# Description

Added basic integration of scheduler and server

closes #8009

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Hugo-Inmanta added a commit that referenced this issue Sep 9, 2024
@Hugo-Inmanta
Revert "Integrate scheduler with server (Issue #8009, PR #8050)"
5b465fc 
This reverts commit 22eab72.
Hugo-Inmanta added a commit that referenced this issue Sep 9, 2024
@Hugo-Inmanta
Revert "Integrate scheduler with server (Issue #8009, PR #8050)"
904db9d 
This reverts commit 22eab72.
Hugo-Inmanta added a commit that referenced this issue Sep 9, 2024
@Hugo-Inmanta @wouterdb
Revert "Integrate scheduler with server (Issue #8009, PR #8050)" (#8071)
95f7f3c 
* Revert "Integrate scheduler with server (Issue #8009, PR #8050)"

This reverts commit 22eab72.

* fix mypy baseline

* added type fixes

* Added typing fixes

---------

Co-authored-by: Wouter De Borger <wouter.deborger@inmanta.com>
inmantaci pushed a commit that referenced this issue Sep 10, 2024
@sanderr @inmantaci
Integrate scheduler with server (Issue #8009, PR #8050)
2489e0e 
# Description

Added basic integration of scheduler and server

closes #8009

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlloreda hlloreda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scheduler server side inmanta/inmanta-core
2 participants
@sanderr @hlloreda