Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'const' fix and support for specifying retina devices for subliminal-test #45

Merged
merged 2 commits into from
Jul 17, 2013
+3 −3
Merged

'const' fix and support for specifying retina devices for subliminal-test #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d5540c
- Added 'const' qualifier to the filename parameter because __FILE__ …
Jul 16, 2013
afd6a47
- Add single quotes to device model name before it's passed to the 'd…
Jul 16, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Classes/SLTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@
@param filename A filename, i.e. the last component of the `__FILE__` macro's expansion.
@param lineNumber A line number, i.e. the `__LINE__` macro's expansion.
*/
- (void)recordLastKnownFile:(char *)filename line:(int)lineNumber;
- (void)recordLastKnownFile:(const char *)filename line:(int)lineNumber;

/**
Records the current filename and line number and returns its argument.
Expand Down
2 changes: 1 addition & 1 deletion Sources/Classes/SLTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ - (void)wait:(NSTimeInterval)interval {
[NSThread sleepForTimeInterval:interval];
}

- (void)recordLastKnownFile:(char *)filename line:(int)lineNumber {
- (void)recordLastKnownFile:(const char *)filename line:(int)lineNumber {
_lastKnownFilename = [@(filename) lastPathComponent];
_lastKnownLineNumber = lineNumber;
}
Expand Down
2 changes: 1 addition & 1 deletion Supporting Files/CI/set_simulator_device
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if [[ -z "$DEVICE" ]]; then
fi

# Change device type
defaults write com.apple.iphonesimulator SimulateDevice "$DEVICE"
defaults write com.apple.iphonesimulator SimulateDevice "'$DEVICE'"

# Restart simulator
killall "iPhone Simulator" 2> /dev/null
Expand Down