'const' fix and support for specifying retina devices for subliminal-test #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2013 14:05
…expands to const char * - This fixes compiler warnings: "Sending 'const char [61]' to parameter of type 'char *' discards qualifiers"
…efaults' command. Device model names with spaces ( e.g. 'iPhone (Retina 4-inch)' ) require single-quoting.
wearhere
added a commit
that referenced
this pull request
Jul 17, 2013
'const' fix and support for specifying retina devices for subliminal-test
|
Thanks @nzhuk! Good call on creating a new PR rather than bothering with rebasing. :) |
|
Yeah, I have to learn to use git properly at some better time. My brains are still too much in hg mode, where rewriting history is considered an exception (although it's certainly technically possible) |
|
Our take at Inkling is, rebase your own (local) history all you like; rebase PRs in consultation with reviewers; never rebase master (barring some terrible mistake). Basically, use rebasing to make changes as clean as possible--before they enter canon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces previous pull request ( #43 )