Fix packet forwarding tests #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soareschen
reviewed
Jan 24, 2023
| port: &str, | ||
| memo: &str, | ||
| ) -> Result<(), Error> { | ||
| simple_exec( |
There was a problem hiding this comment.
Once this is working, we should update ibc-proto-rs to include the memo field, and have another PR to update this method to submit the transaction within Rust.
romac
requested changes
Jan 24, 2023
5 tasks
romac
approved these changes
Jan 25, 2023
|
💯 |
yito88
added a commit
to heliaxdev/hermes
that referenced
this pull request
Apr 17, 2024
yito88
added a commit
to heliaxdev/hermes
that referenced
this pull request
Apr 30, 2024
yito88
added a commit
to heliaxdev/hermes
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3025
Description
This PR updates the tests for Packet Forwarding.
As of version
3.0.0, https://github.com/strangelove-ventures/packet-forward-middleware/releases/tag/v3.0.0, of the packet-forward-middleware, the memo field is used instead of a specific receiver address, see https://github.com/strangelove-ventures/packet-forward-middleware#examples.Chains using new packet-forward-middleware
simdstarting from version5.1.0,simddoesn't have the packet forwarding middleware enabled.gaiadstarting from version8.0.0-rc1, https://github.com/cosmos/gaia/blob/main/CHANGELOG.md#v800-rc1---2023-01-06PR author checklist:
unclog.Updated code comments and documentation (e.g.,docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.