Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward_transfer test to match the updated API #3025

Closed
5 tasks
Tracked by #3005 ...
soareschen opened this issue Jan 23, 2023 · 0 comments · Fixed by #3032
Closed
5 tasks
Tracked by #3005 ...

Fix forward_transfer test to match the updated API #3025

soareschen opened this issue Jan 23, 2023 · 0 comments · Fixed by #3032
Assignees
Labels
I: dependencies Internal: related to dependencies O: ics29-fee Objective: Fee middleware support O: tests Objective: Test more aspect of the relayer

Comments

@soareschen
Copy link
Contributor

Summary

The forward_transfer test is failing on Gaia v8.0.0-rc3 in #3019. The likely reason for this is that the packet forward middleware has been updated with a new API as specified here.

The test needs to be fixed so that it works with the new version of the packet forward middleware.

As for whether to keep the original behavior on Gaia v6, my current understanding that there is no need for that, as the feature is not currently in use. However it would be good to double check whether we need to support both behaviors at the same time. Nevertheless, the support for v8 takes precedence over older versions.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jan 23, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🏗 In progress in Hermes Jan 23, 2023
@seanchen1991 seanchen1991 added O: tests Objective: Test more aspect of the relayer I: dependencies Internal: related to dependencies O: ics29-fee Objective: Fee middleware support labels Jan 23, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies O: ics29-fee Objective: Fee middleware support O: tests Objective: Test more aspect of the relayer
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants