Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.http): Rework token options #13622

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 14, 2023

relates to #9455

This PR adds a new token option that allows to directly specify a token or to reference a secret store entry. Together with PR #13621 (and potentially other secret-stores) this offers a powerful way to dynamically update the tokens in an arbitrary manner. Furthermore, this PR renames the bearer_token option to token_file for clarity and deprecates the former.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 14, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 14, 2023
@srebhan srebhan requested a review from Hipska July 14, 2023 14:20

Log telegraf.Logger `toml:"-"`
Headers map[string]string `toml:"headers"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Headers better fits with the block of Method, Body and encoding?

@srebhan srebhan merged commit 0ba4638 into influxdata:master Jul 14, 2023
@srebhan srebhan deleted the http_token_rework branch July 14, 2023 14:52
@github-actions github-actions bot added this to the v1.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants