Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secretstores): Add secret-store to access OAuth2 services #13621

Merged
merged 9 commits into from
Jul 14, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 14, 2023

related to #9455

This PR adds a secret-store to retrieve tokens from an OAuth2 service and make them available to other plugins. The tokens are automatically renewed on expiry so other plugins don't need to care.

Tested with curity.io and AzureAD.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 14, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 14, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, couple sampel.conf changes - I may grab some of this for influxctl too :)

Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

srebhan and others added 5 commits July 14, 2023 16:15
Co-authored-by: Joshua Powers <powersj@fastmail.com>
Co-authored-by: Joshua Powers <powersj@fastmail.com>
Co-authored-by: Joshua Powers <powersj@fastmail.com>
Co-authored-by: Joshua Powers <powersj@fastmail.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 56075a9 into influxdata:master Jul 14, 2023
@github-actions github-actions bot added this to the v1.28.0 milestone Jul 14, 2023
@Hipska
Copy link
Contributor

Hipska commented Apr 25, 2024

Just saw this pr didn't "Updated associated README.md": https://github.com/influxdata/telegraf/blob/master/plugins/secretstores/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants