Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reenable OpenBSD modbus support #10385

Merged
merged 7 commits into from
Jan 7, 2022
Merged

fix: Reenable OpenBSD modbus support #10385

merged 7 commits into from
Jan 7, 2022

Conversation

geowiwi
Copy link
Contributor

@geowiwi geowiwi commented Jan 5, 2022

This is a follow-up to: #10047

  • update modules for serial and modbus
  • reenable modbus support on OpenBSD
  • update wireguard/wgctrl for OpenBSD/arm64 support

YMMV on go.mod line 371, in my case the workaround was not necessary anymore.

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 5, 2022

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@geowiwi geowiwi mentioned this pull request Jan 5, 2022
3 tasks
@geowiwi
Copy link
Contributor Author

geowiwi commented Jan 5, 2022

!signed-cla

@reimda reimda changed the title Improve OpenBSD support fix: Reenable OpenBSD modbus support Jan 6, 2022
@reimda
Copy link
Contributor

reimda commented Jan 6, 2022

Hi @geowiwi, thanks for the PR! It will be nice to have modbus working on OpenBSD again. The PR doesn't build on linux or windows. Will you fix the imports for those platforms so CI will pass, then we'll get this reviewed and merged?

@geowiwi
Copy link
Contributor Author

geowiwi commented Jan 6, 2022

@reimda: please note wireguard/wgctrl update is only related to OpenBSD/arm64 support

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @geowiwi. Looks good to me.

@srebhan srebhan self-assigned this Jan 7, 2022
@srebhan srebhan added area/modbus plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 7, 2022
@powersj powersj merged commit 0e10313 into influxdata:master Jan 7, 2022
powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@geowiwi
Copy link
Contributor Author

geowiwi commented Mar 20, 2022

@powersj

I noticed the bits related to wgctrl already made it to 1.21.4 in fda08c5.

Will the serial-x update make 1.21.5 or is this scheduled for a later release?

@powersj
Copy link
Contributor

powersj commented Mar 21, 2022

This PR will go out in v1.22.0 this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants