-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reenable OpenBSD modbus support #10385
Conversation
Thanks so much for the pull request! |
!signed-cla |
Hi @geowiwi, thanks for the PR! It will be nice to have modbus working on OpenBSD again. The PR doesn't build on linux or windows. Will you fix the imports for those platforms so CI will pass, then we'll get this reviewed and merged? |
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
@reimda: please note wireguard/wgctrl update is only related to OpenBSD/arm64 support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @geowiwi. Looks good to me.
This PR will go out in v1.22.0 this week. |
This is a follow-up to: #10047
YMMV on go.mod line 371, in my case the workaround was not necessary anymore.