-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not build modbus on openbsd #10047
Conversation
😄 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @powersj for the fix. Code looks good even though I would prefer fixing the underlying library to provide modbus support for OpenBSD... :-)
(cherry picked from commit ce46506)
OpenBSD support in the underlying library was fixed in: Associated pull request: #10385 |
This is the remaining plugin that is blocking builds on OpenBSD. The issue is the github.com/grid-x/serial library does not build on OpenBSD. That library is an indirect import, due to github.com/grid-x/modbus. Upgrading modbus does not help the situation as it does not pull in a newer version of the grid-x/serial.
Because this is the only one, I figured it is simpler to stop building this on openbsd until someone comes by with a better solution.
Required for all PRs:
resolves #10034