Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update shirou/gopsutil to v3 #10119

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

PierreF
Copy link
Contributor

@PierreF PierreF commented Nov 17, 2021

Required for all PRs:

At the end of the month, gopsutil will drop support for version 2 1. This PR migrate to v3 of gopsutil.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Nov 17, 2021
@PierreF PierreF force-pushed the upgrade-gopsutil-v3 branch from ef7e769 to bbd64f5 Compare November 17, 2021 17:18
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Good to do this before V2 support is dropped.

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 17, 2021
Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! I resolved some conflicts but this is ready to go once the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants