Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): make rpm verify pass after installation #13397

Merged
merged 1 commit into from
Apr 30, 2019
Merged

fix(package): make rpm verify pass after installation #13397

merged 1 commit into from
Apr 30, 2019

Conversation

affo
Copy link
Contributor

@affo affo commented Apr 15, 2019 •
edited by jsternberg
Loading

This change sets the ownership of directories on package generation with fpm instead that in post-install to make rpm -V pass.

For more details, see: influxdata/EAR#716

Briefly describe your proposed changes:

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@affo
Copy link
Contributor Author

affo commented Apr 15, 2019

I think this would need backport.

@affo affo requested a review from e-dard April 15, 2019 08:17
@affo affo mentioned this pull request Apr 19, 2019
Merged
5 tasks
@e-dard
Copy link
Contributor

e-dard commented Apr 23, 2019

@affo I don't know enough about this to review it. @mark-rushakoff might have a better insight.

@e-dard e-dard requested review from mark-rushakoff and removed request for e-dard April 23, 2019 11:53
@affo
Copy link
Contributor Author

affo commented Apr 30, 2019

@mark-rushakoff I added the chmod lines and moved user creation to pre-install phase.

I did because of an issue with rpm-attr and non-existing user at installation time (see https://github.com/influxdata/EAR/issues/716#issuecomment-487758645).

@affo affo requested a review from mark-rushakoff April 30, 2019 10:13
@affo affo merged commit e10a0fa into 1.8 Apr 30, 2019
@affo affo deleted the fix/rpm-verify branch April 30, 2019 16:54
@affo affo mentioned this pull request May 2, 2019
Merged
5 tasks
@affo affo mentioned this pull request May 17, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnaraasen gunnaraasen gunnaraasen left review comments

@mark-rushakoff mark-rushakoff mark-rushakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@affo @e-dard @mark-rushakoff @gunnaraasen