Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): make rpm verify pass after installation #5146

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Conversation

affo
Copy link
Contributor

@affo affo commented Apr 15, 2019

This change sets the ownership of directories on package generation with fpm instead that in post-install to make rpm -V pass.

For more details, see: influxdata/EAR#716

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • swagger.json updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@affo
Copy link
Contributor Author

affo commented Apr 15, 2019

It is not clear to me how these changes should be related to these files in the InfluxDB repo: https://github.com/influxdata/influxdb/tree/master/chronograf/etc

Copy link
Contributor

@gunnaraasen gunnaraasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what is intended but I'm not familiar enough with RPM to know if this is the right way for RPM.

@affo
Copy link
Contributor Author

affo commented Apr 19, 2019

Looks like it does what is intended but I'm not familiar enough with RPM to know if this is the right way for RPM.

Thank you @gunnaraasen for the review. I am not super-familiar with RPM too, however I tested it manually on a CentOS container and it works.

It is worth mentioning that this PR applies the same code as others that got merged in Telegraf (influxdata/telegraf#5716) and Kapacitor (influxdata/kapacitor#2186). The same is for InfluxDB, but I still need a review on that (influxdata/influxdb#13397). I am trying to keep the code consistent among them, although I need to update Kapacitor's one post-install.sh to match this implementation.

@affo affo merged commit 2930d4a into master Apr 19, 2019
@affo affo deleted the fix/rpm-verify branch April 19, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants