Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update issue links in SPEC.md #5190

Merged
merged 2 commits into from
Sep 12, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions docs/SPEC.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ The following keywords are reserved and may not be used as identifiers:
and import not return option test
empty in or package builtin

[IMPL#256](https://github.com/influxdata/platform/issues/256) Add in and empty operator support
[IMPL#256](https://github.com/influxdata/flux/issues/764) Add in and empty operator support

#### Operators

Expand All @@ -120,7 +120,7 @@ The following coercion rules apply to numeric literals:
* an error will occur if the coerced type cannot represent the literal value.


[IMPL#255](https://github.com/influxdata/platform/issues/255) Allow numeric literal coercion.
[IMPL#255](https://github.com/influxdata/flux/issues/476) Allow numeric literal coercion.

##### Integer literals

Expand Down Expand Up @@ -159,7 +159,7 @@ Examples:
2.71828
.26

[IMPL#254](https://github.com/influxdata/platform/issues/254) Parse float literals
<!-- [IMPL#254](https://github.com/influxdata/platform/issues/254) Parse float literals -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's utility in keeping this commented out. Should we not just remove it?

I wonder if this, and the others are commented out because no equivalent issue was filed in the current repo(s).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, lemme go back and review these!


#### Duration literals

Expand Down Expand Up @@ -247,7 +247,7 @@ Examples:
2018-01-31T00:00:00Z + 1mo * 2 // 2018-03-31T00:00:00Z
2018-01-31T00:00:00Z + 1mo * 3 // 2018-04-30T00:00:00Z

[IMPL#657](https://github.com/influxdata/platform/issues/657) Implement Duration vectors
[IMPL#657](https://github.com/influxdata/flux/issues/413) Implement Duration vectors

#### Date and time literals

Expand Down Expand Up @@ -319,7 +319,7 @@ A function "printf" exists to allow more precise control over formatting of vari
To include the literal `${` within a string it must be escaped.


[IMPL#248](https://github.com/influxdata/platform/issues/248) Add printf function
[IMPL#248](https://github.com/influxdata/flux/issues/731) Add printf function

Interpolation example:

Expand Down Expand Up @@ -423,7 +423,7 @@ The default value is set using the time zone of the running process.
option location = fixedZone(offset:-5h) // set timezone to be 5 hours west of UTC
option location = loadLocation(name:"America/Denver") // set location to be America/Denver

[IMPL#660](https://github.com/influxdata/platform/issues/660) Implement Location option
<!-- [IMPL#660](https://github.com/influxdata/platform/issues/660) Implement Location option -->

### Types

Expand Down Expand Up @@ -498,7 +498,7 @@ Examples:
2018-07-01T00:00:00Z + 2y // 2020-07-01T00:00:00Z
2018-07-01T00:00:00Z + 5h // 2018-07-01T05:00:00Z

[IMPL#2026](https://github.com/influxdata/flux/issues/2026)
<!-- [IMPL#2026](https://github.com/influxdata/flux/issues/2026) -->

#### Binary types

Expand Down Expand Up @@ -577,7 +577,7 @@ A _function type_ represents a set of all functions with the same argument and r
A _generator type_ represents a value that produces an unknown number of other values.
The generated values may be of any other type but must all be the same type.

[IMPL#658](https://github.com/influxdata/platform/issues/658) Implement Generators types
<!-- [IMPL#658](https://github.com/influxdata/platform/issues/658) Implement Generators types -->

#### Polymorphism

Expand Down Expand Up @@ -735,7 +735,6 @@ Note that the package clause is not an assignment.
The package name does not appear in any scope.
Its purpose is to identify the files belonging to the same package and to specify the default package name for import declarations.

[IMPL#247](https://github.com/influxdata/platform/issues/247) Add package/namespace support

#### Variable assignment

Expand Down Expand Up @@ -1065,7 +1064,6 @@ The package clause must be at the begining of any Flux source file.
All files in the same package must declare the same package name.
When a file does not declare a package clause, all identifiers in that file will belong to the special _main_ package.

[IMPL#247](https://github.com/influxdata/platform/issues/247) Add package/namespace support

##### package main

Expand Down