fix(docs): Update issue links in SPEC.md #5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've update the links to point to the issues in this repo. A few have been closed; I've removed those links.
onelson
reviewed
Sep 12, 2022
docs/SPEC.md
Outdated
| @@ -159,7 +159,7 @@ Examples: | |||
| 2.71828 | |||
| .26 | |||
|
|
|||
| [IMPL#254](https://github.com/influxdata/platform/issues/254) Parse float literals | |||
| <!-- [IMPL#254](https://github.com/influxdata/platform/issues/254) Parse float literals --> | |||
There was a problem hiding this comment.
I wonder if there's utility in keeping this commented out. Should we not just remove it?
I wonder if this, and the others are commented out because no equivalent issue was filed in the current repo(s).
There was a problem hiding this comment.
Ah yes, lemme go back and review these!
onelson
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've update the links to point to the issues in this repo.
A few have been closed; I've removed those links.
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedNo changes to lang, but this does update SPEC.md.
Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.