-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add write_dwc()
function
#257
Conversation
Note: Calculating the number of records per group is however much slower than the current approach. Do you consider it worth to provide this information at the cost of performance? Update: currently blocked by #259. Using the function on project |
For those who cannot run the function, here's the DwC file dwc_occurrence.csv for the following query:
|
Regarding #257 (comment): Count per group is now included as |
Only a couple of pending questions to finalize this: #256 (comment) |
All Darwin Core mapping issues are resolved (#256). @jreubens @jonasmortelmansvliz @jdpye note that the current implementation only exports an Occurrence core (cf. Movebank data), not an Extended measurement or fact extension. The latter could be added in the future, but it should then be discussed what to express in there (scope potentially huge). This PR is pending
|
The requested views have been removed from the database, see #226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging I suggest the following changes:
- replace expect_equal with expect_identical where appropriate
- Allow write_dwc() to return objects rather than files
The latter similar to inbo/camtraptor#181
@PietrH all comments addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Super belatedly, I checked out the sql and example output dwc_occurrence (without access to the LifeWatch server), it all looks sensible to me. Happy to coordinate with ETN at any point on aligning future changes with Movebank. Thank you for all the work @peterdesmet ! |
Implements #256
@jreubens @jonasmortelmansvliz @damianooldoni @jdpye @sarahcd here's a first version of the
write_dwc()
function that transforms acoustic telemetry data to Darwin Core that can be harvested by OBIS and GBIF. It follows the recommendations we discussed, which are based on conventions introduced for Movebank data in the movepubwrite_dwc()
function. Aneml.xml
file is not created.You can test it by installing:
@jdpye @sarahcd this will work on LifeWatch RStudio Server only for now, but you can see the SQL file in this PR to see the transformation.
Then:
If all goes well, a
dwc_occurrence.csv
will be written to disk.