Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with changes to helper functions, collapse_transformer() is no longer in use #264

Closed
PietrH opened this issue Dec 7, 2022 · 1 comment · Fixed by #257
Closed

with changes to helper functions, collapse_transformer() is no longer in use #264

PietrH opened this issue Dec 7, 2022 · 1 comment · Fixed by #257
Assignees
@PietrH
Labels
enhancement New feature or request

Comments

@PietrH
Copy link
Member

PietrH commented Dec 7, 2022

In #257 (see also #256) the helper functions were revised: zzz.R -> utils.R including a change to check_value() where helper function collapse_transformer() was called.

With the changes to check_value() in the pull request, collapse_transformer is no longer in use and can be removed.
@peterdesmet
Copy link
Member

Yes collapse_transformer can be removed now that is no longer used (glue_collapse() is used instead).

PietrH added a commit that referenced this issue Dec 7, 2022
@PietrH
remove collapse_transformer: unused
18404e6 
Fix #264
@PietrH PietrH linked a pull request Dec 8, 2022 that will close this issue
Add write_dwc() function #257
Merged
@PietrH PietrH added the enhancement New feature or request label Dec 8, 2022
@PietrH PietrH mentioned this issue Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PietrH PietrH

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add write_dwc() function inbo/etn
2 participants
@peterdesmet @PietrH