Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken yml for GitHub Actions #143

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Fix broken yml for GitHub Actions #143

merged 6 commits into from
Dec 16, 2020

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

No description provided.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

It seems to now be failing due to a failing rebar3 version (the one packed with the Docker container).

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as draft December 14, 2020 03:22
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Converting to draft to check if Action setup-erlang would solve the (apparently caused by) rebar3 issues.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I'm trying to make CI's rebar3 not change between different containers. While this isn't done, I'm going to use setup-erlang for a quick fix.

@paulo-ferraz-oliveira
Try to fix rebar3 version errors by changing CI strategy
2c3ad2f 
(we move from a Docker Container to a GitHub Action)
@paulo-ferraz-oliveira
Copy link
Collaborator Author

List of Erlang versions is currently: 19.3, 20.0, 21.3, 22.3, 23.1
List of setup-erlang supported version is currently: http://packages.erlang-solutions.com/erlang/debian/pool/.

I'll need to fix the mismatch.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Dec 15, 2020 •
edited
Loading

Still not Okay :( it seems setup-erlang prefixes the version with https://packages.erlang-solutions.com/erlang/debian/pool/esl-erlang_erlang: and suffixes it with -1~ubuntu~bionic_amd64.deb, so I need to work with that.

Edit: actually, no, the erlang: bit is a stupid typo on my behalf.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review December 16, 2020 02:53
@elbrujohalcon
Copy link
Member

Looks reasonable to me.

@elbrujohalcon elbrujohalcon merged commit 1a284cb into inaka:master Dec 16, 2020
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/gha branch December 18, 2020 17:44
@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Jan 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ferraz-oliveira @elbrujohalcon