Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aim for the same rebar3 vsn across the board #317

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Aim for the same rebar3 vsn across the board #317

merged 2 commits into from
Dec 16, 2020

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

My goal here is to remove a variable from potential CI processes.
I've had jobs fail in erlang:19:3 but not in erlang:23.1 due to rebar3 -specific issues (that we're left unsolved in previous versions, but not in the most recent ones).

@getong
Copy link
Collaborator

getong commented Dec 15, 2020

Sorry for the delay. I used to update the rebar3 version with the erlang version is updated, but if you do need to update all the rebar3 version, I am happy to merge it. Would you update the alpine directory rebar3 version and rebase your pr?

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Dec 15, 2020

We need the update since this is failing on CI. Imagine running 19.3, 20.3, 21.3, 22.3, etc. and failing in 19.3 because of rebar3 (not the app or CI itself) 😄

What branch should I rebase this off of (or are you mentioning rebase in the sense of squash)?

@paulo-ferraz-oliveira
Copy link
Contributor Author

@getong: I added bee9618 to change the alpine folders, master and README.md. It's now the same version from 19 to 23, the same versions rebar3 supports. Would you like further changes (or changes to existing ones)?

@getong getong merged commit 7749928 into erlang:master Dec 16, 2020
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/same_rebar3 branch December 16, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants