fix: pr template not being used and make some changes #15893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasFlamy
commented
Feb 3, 2025
NicholasFlamy
commented
Feb 3, 2025
| - [ ] Test A | ||
| - [ ] Test B | ||
|
|
||
| <details><summary><h2>Screenshots (if appropriate)</h2></summary> |
There was a problem hiding this comment.
Made this a dropdown so that images won't take up the entire screen.
NicholasFlamy
commented
Feb 3, 2025
.github/pull_request_template.md
Outdated
Comment on lines
31
to
36
| - [ ] I have no unrelated changes in the PR. | ||
| - [ ] I have confirmed that any new dependencies are strictly necessary. | ||
| - [ ] I have written unit tests for new code (if applicable) | ||
| - [ ] I have followed naming conventions/patterns in the surrounding code | ||
| - [ ] All code in `domain/` uses repositories for implementations of database calls, filesystem operations, etc. | ||
| - [ ] All code in `infra/` is pretty basic/simple and does not have any immich specific logic (that belongs in domain) |
There was a problem hiding this comment.
Added jrasm91 checklist items from https://discord.com/channels/979116623879368755/1071165397228855327/1335978945031442442
7efe4c0 to
534059e
Compare
534059e to
71896a2
Compare
|
Should now be one commit with all the changes and suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the GitHub PR Template file so that it is used for issues. I also made some changes and included some more checklist points from @jrasm91.
How Has This Been Tested?
Checklist:
domain/uses repositories for implementations of database calls, filesystem operations, etc.infra/is pretty basic/simple and does not have any immich specific logic (that belongs in domain)