Skip to content

Commit

Permalink
fix-pr-template-and-make-some-changes-with-suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
NicholasFlamy committed Feb 4, 2025
1 parent 69e88ef commit 534059e
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 23 deletions.
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
blank_issues_enabled: false
blank_pull_request_template_enabled: false
22 changes: 0 additions & 22 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

This file was deleted.

36 changes: 36 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
## Description

<!--- Describe your changes in detail -->
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

Fixes # (issue)

## How Has This Been Tested?

<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration -->

- [ ] Test A
- [ ] Test B

<details><summary><h2>Screenshots (if appropriate)</h2></summary>

<!-- Images go below this line. -->

</details>

<!-- API endpoint changes (if relevant)
## API Changes
The `/api/something` endpoint is now `/api/something-else`
-->

## Checklist:

- [ ] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation if applicable
- [ ] I have no unrelated changes in the PR.
- [ ] I have confirmed that any new dependencies are strictly necessary.
- [ ] I have written tests for new code (if applicable)
- [ ] I have followed naming conventions/patterns in the surrounding code
- [ ] All code in `src/services` uses repositories implementations for database calls, filesystem operations, etc.
- [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services`)

0 comments on commit 534059e

Please sign in to comment.