-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added blueprints for create-v2-addon-repo (Part 3) #14
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3815b63
refactor: Simplified scripts
ijlee2 7b6b4f8
refactor: Created a script to update blueprints-addon
ijlee2 0ea59e5
bugfix: Added a suffix to guarantee unique names (prevent runtime err…
ijlee2 0a8c766
chore: Updated blueprints
ijlee2 71f19f5
chore: Hid blueprint for *-test.gts behind a feature flag
ijlee2 78f91cd
chore: Renamed examples (want to avoid numbers for components)
ijlee2 84aefcb
chore: Renamed --blueprint-type to --blueprint
ijlee2 add825a
chore: Updated fixtures (blueprints-addon)
ijlee2 f851403
chore: Ran update-blueprints-addon
ijlee2 d385405
chore: Updated blueprints
ijlee2 787bdcf
chore: Updated fixtures (create-v2-addon-repo)
ijlee2 46ea2a9
chore: Added changeset
ijlee2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"create-v2-addon-repo": minor | ||
"blueprints-addon": minor | ||
--- | ||
|
||
Added blueprints for create-v2-addon-repo (Part 3) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
15 changes: 15 additions & 0 deletions
15
.../tests/fixtures/run-destroy/input/packages/ui/button/src/components/my-example/glimmer.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import Component from '@glimmer/component'; | ||
|
||
import styles from './glimmer.css'; | ||
|
||
interface MyExampleGlimmerSignature { | ||
Args: {}; | ||
Blocks: { | ||
default: []; | ||
}; | ||
Element: null; | ||
} | ||
|
||
export default class MyExampleGlimmerComponent extends Component<MyExampleGlimmerSignature> { | ||
styles = styles; | ||
} |
File renamed without changes.
File renamed without changes.
20 changes: 20 additions & 0 deletions
20
.../fixtures/run-destroy/input/packages/ui/button/src/components/my-example/template-tag.gts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import Component from '@glimmer/component'; | ||
|
||
import styles from './template-tag.css'; | ||
|
||
interface MyExampleTemplateTagSignature { | ||
Args: {}; | ||
Blocks: { | ||
default: []; | ||
}; | ||
Element: null; | ||
} | ||
|
||
// eslint-disable-next-line ember/no-empty-glimmer-component-classes | ||
export default class MyExampleTemplateTagComponent extends Component<MyExampleTemplateTagSignature> { | ||
<template> | ||
<div class={{styles.container}}> | ||
{{yield}} | ||
</div> | ||
</template> | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
Configure
eslint
andtypescript
so thatlint:fix
doesn't error when there are*.gts
files intest-app
.