Added blueprints for create-v2-addon-repo (Part 3) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
Aug 16, 2024
Comment on lines
+12
to
+22
| function getFilesToSkip(): string[] { | ||
| const files = new Set<string>(); | ||
|
|
||
| if (ENABLE_TEMPLATE_TAG) { | ||
| files.add('__fileName__.ts'); | ||
| } else { | ||
| files.add('__fileName__.gts'); | ||
| } | ||
|
|
||
| return Array.from(files); | ||
| } |
There was a problem hiding this comment.
TODO
Configure eslint and typescript so that lint:fix doesn't error when there are *.gts files in test-app.
61503bf to
7e37289
Compare
ijlee2
commented
Aug 16, 2024
| @@ -30,7 +30,6 @@ | |||
| "@ember/optional-features": "^2.1.0", | |||
| "@ember/string": "^3.1.1", | |||
| "@ember/test-helpers": "^3.3.0", | |||
| "@embroider/broccoli-side-watch": "0.0.2-unstable.ba9fd29", | |||
There was a problem hiding this comment.
TODO
Check if this is still needed in docs-app and test-app. Live reload seemed to work without in test-app.
7e37289 to
39d1c2a
Compare
39d1c2a to
a4b2ed9
Compare
a4b2ed9 to
46ea2a9
Compare
ijlee2
commented
Aug 16, 2024
| path: | | ||
| packages/**/declarations/**/* | ||
| packages/**/dist/**/* | ||
| packages/.gitkeep |
There was a problem hiding this comment.
TECHNICAL RISK
actions/download-artifact@v4 errors when there is no artifact to download, and doesn't provide an option to avoid this error. To help CI pass from the start, I added packages/.gitkeep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.