-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for citations and input file formats #26
Conversation
This is done to prepare for the next pyam update, see IAMconsortium/pyam#706 (comment)
Looks like a test is failing because of a
|
I guess there's two ways of fixing this, pinning the numpy version or changing |
Yes - just need to find where it is actually used, will try and go down the rabbit hole |
If you, for now, pin the version at |
OK. Have made an issue on openscm-runner; openscm/openscm-runner#81 |
Thanks for the MR and diagnosis. If the current master branch of openscm-runner fixes the tests, I'll make a new release. |
Okay - thanks @lewisjared! Let me know when we can/should update the dependency, since it was so far pinned on 0.9.1. |
Sorry I missed this. I just cut a new release so that should be available in the next hour |
Hitting a few roadblocks regarding test coverage so it might not be resolved today, but I'll fix as soon as I can |
setup.cfg
Outdated
@@ -35,7 +34,7 @@ install_requires = | |||
importlib-metadata | |||
joblib | |||
matplotlib | |||
numpy | |||
numpy<= 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the pin is removed and the tests run, good to merge from my side.
Adjusted, and passing tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks @jkikstra
Updates documentation:
Adresses #25