Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Cleanup failing CI #83

Merged
merged 4 commits into from
May 15, 2023
Merged

chore(ci): Cleanup failing CI #83

merged 4 commits into from
May 15, 2023

Conversation

lewisjared
Copy link
Collaborator

@lewisjared lewisjared commented May 12, 2023 •
edited
Loading

This fixes the broken CI with some additional linting exceptions

This also pins fair to < 2

  • Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/openscm/openscm-runner/pull/XX>`_) Added feature which does something)

@lewisjared lewisjared temporarily deployed to CI May 12, 2023 10:49 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 10:49 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 10:49 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 11:05 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 11:05 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 11:05 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 13:01 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 13:01 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 12, 2023 13:01 — with GitHub Actions Inactive
@lewisjared
Copy link
Collaborator Author

lewisjared commented May 12, 2023 •
edited
Loading

@znicholls Your hunch was right. pytest-cov updated to v4.0.0 since the last time the CI was run which removed some of the multiprocessing coverage functionality https://pytest-cov.readthedocs.io/en/latest/changelog.html.

I'll release this as v0.12.1 once merged

@lewisjared lewisjared requested a review from znicholls May 12, 2023 13:01
znicholls
znicholls approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:40 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:41 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:41 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:41 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:41 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:41 — with GitHub Actions Inactive
@lewisjared lewisjared temporarily deployed to CI May 15, 2023 11:41 — with GitHub Actions Inactive
@lewisjared lewisjared merged commit a4de61d into master May 15, 2023
@lewisjared lewisjared deleted the resolve-failing-ci branch May 15, 2023 12:15
@lewisjared lewisjared mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholls znicholls znicholls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewisjared @znicholls