Standartize metadata for all objects on Adventure Map

[ihhub]

• remove cryptic quantity1 and quantity2 values everywhere in the code and replace them with human-readable metadata array
• avoid hardcoded values for many object conditions like Artifact, Daemon Cave or Shipwreck
• fix AI pathfinding when Spell Scroll was considered as an artifact which requires to defeat an army
• fix Shipwreck Survivor bonuses. It always contained artifact of level 1
• add many checks in the code to prevent calling functions for unsupported objects
• add specialized functions to get information about objects. We have to avoid generic functions

relates to #6845

ATTENTION
This pull request changes almost every object interaction on Adventure Map in relation to conditions and resources. Also I added a conversion code from old save format to a new one. As a result, it is important to test all objects for new maps as well as objects on maps loaded from old saves.

The best strategy for testing by developers is to enable debug mode and see metadata values on objects. Now it is easily readable.

[github-actions]

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

[github-actions]

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

[github-actions]

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

[LeHerosInconnu]

Hello @ihhub,

Hi @LeHerosInconnu, could you please help to test changes in this pull request? We need your comprehensive testing skills for this pull request.

Are there any other changes planned before I start the test?

[ihhub]

Hello @ihhub,

Hi @LeHerosInconnu, could you please help to test changes in this pull request? We need your comprehensive testing skills for this pull request.

Are there any other changes planned before I start the test?

Nope. I've recently fixed some issues found by @Branikolog and reported through Discord. As of now only bug fixing. You can download the newer version once the compilation is done.

[oleg-derevenetz]

Hi @ihhub is this fine that when Tree of Knowledge has no resource requirement, there is "unknown resource" warning printed in the Funds constructor? It doesn't interfere with the game, but it looks weird and litters the log with messages about what is not really a problem.

[ihhub]

Tree of Knowledge

Hi @oleg-derevenetz , actually it is wrong. This message is added to avoid bad written code. I will have a look at it. Thank you for spotting it!

[ihhub]

@oleg-derevenetz , fixed!

[oleg-derevenetz]

@ihhub

fixed!

What do you think about the following fixing method instead: allow to pass the Resource::UNKNOWN value to the Funds constructor (add the special switch case with just break and maybe also a check that count is zero as well and log a warning if it is not, because there cannot be non-zero amount of unknown resource)? Or this is undesirable?

[ihhub]

What do you think about the following fixing method instead: allow to pass the Resource::UNKNOWN value to the Funds constructor (add the special switch case with just break and maybe also a check that count is zero as well and log a warning if it is not, because there cannot be non-zero amount of unknown resource)? Or this is undesirable?

I think we should prevent even passing unknown types into the constructor. This might help to find some future issues with wrong code or wrong data read from files. Of course no harm by doing this but in my view we should log such undesired behavior.

[oleg-derevenetz]

Hi @ihhub there is the same issue in the Maps::getFundsFromTile(): non-pickable objects may contain no funds.

[ihhub]

Hi @ihhub there is the same issue in the Maps::getFundsFromTile(): non-pickable objects may contain no funds.

... I shall add the case with zero unknown resources :(

[LeHerosInconnu]

Hello @ihhub,

I did a test on a test scenario and did not encounter any problems.
I will do another test playing a standard scenario.

[ihhub]

Thank you @LeHerosInconnu !

[Branikolog]

Haven't found more bugs here. Great job, fheroes2 team! :D

[zenseii]

Hi, @ihhub. I've tested some old saves I had and done a partial read-through of the code. So far I've only found these typos. Please have a look at them when you have time.

[zenseii]

Hi, @ihhub. I've read through all the changes and found only this typo which will need to be changed overall.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
17 Code Smells

0.0% Coverage
5.2% Duplication

[Districh-ru]

I played fully one new standard game and for a couple of week a campaign scenario and a standard game from an old save file. I did not notice any bugs.
Well done!

[LeHerosInconnu]

Hello @ihhub,

Hello @ihhub,

I did a test on a test scenario and did not encounter any problems.
I will do another test playing a standard scenario.

I finished a standard scenario started with the PR version and continued with the merged version without any problems.