Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adventure map, crash during AI turn #7129

Closed
2 tasks done
Branikolog opened this issue May 6, 2023 · 6 comments · Fixed by #7131
Closed
2 tasks done

Adventure map, crash during AI turn #7129

Branikolog opened this issue May 6, 2023 · 6 comments · Fixed by #7131
Assignees
Labels
bug Something doesn't work crash Application crashes. The highest level of priority regression Something went wrong in previous commits
Milestone

Comments

@Branikolog
Copy link
Collaborator

Preliminary checks

Platform

Windows

Describe the bug

Application crashes without any message when blue AI appears in a stone liths near to my hero:
image

Two blue heroes jump into stone liths:
image
App crashes only in a case one of them appears near my hero. (Probably need some reloads to catch this exit exactly)

Save file

crash 01.zip

Additional info

No response

@Branikolog Branikolog added bug Something doesn't work crash Application crashes. The highest level of priority labels May 6, 2023
@Branikolog Branikolog added this to the 1.0.4 milestone May 6, 2023
@Branikolog
Copy link
Collaborator Author

Actually, crashes each time any AI enemy appears in this stone liths.

@oleg-derevenetz
Copy link
Collaborator

oleg-derevenetz commented May 6, 2023

This crash is due to failed assertion on UI turn. That's because ore mine at tile 8543 (that one to the right from the Witch's Hut on your screenshot) has no metadata regarding its production (its _metadata field contains only zeroes). I can reproduce this crash in debug build just by clicking the right mouse button on this mine because of additional debug output that causes this assertion failure as well. I believe it's related to #7084.

@oleg-derevenetz
Copy link
Collaborator

oleg-derevenetz commented May 6, 2023

Hi @Branikolog was this map started on the latest build (at least after merging of #7084) or was it loaded from an earlier save (if yes, can we get this save somehow as well)?

@ihhub
Copy link
Owner

ihhub commented May 7, 2023

It's an Ore Mine at tile 8543 nearby Orange Knight castle. Most likely this save is made from an old one as for a new game it works absolutely fine.

@Branikolog
Copy link
Collaborator Author

Hi, @ihhub and @oleg-derevenetz
I've decided to continue one of my old save files yesterday but overwritten it.
But I've found one from the same walkthrough even more old. Accidentally it's the one with the exact moment I've captured this mine. Which is crashing on the current build.
On older build I can check the mine info without crashes.
221.zip

@ihhub
Copy link
Owner

ihhub commented May 7, 2023

The problem is that there is a hero standing on this mine and since heroes were not loaded at the time of processing metadata for the mine the object type is OBJ_NONE.

@ihhub ihhub self-assigned this May 7, 2023
@ihhub ihhub added the regression Something went wrong in previous commits label May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work crash Application crashes. The highest level of priority regression Something went wrong in previous commits
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants