Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: determining version number in go paths #598

Merged
merged 1 commit into from
Dec 23, 2020
Merged

fix: determining version number in go paths #598

merged 1 commit into from
Dec 23, 2020

Conversation

ilgooz
Copy link
Member

@ilgooz ilgooz commented Dec 23, 2020

fixes #596.

@ilgooz ilgooz requested review from fadeev and lumtis as code owners December 23, 2020 16:51
fadeev
fadeev approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed it! Great 🦖

Do you think we can re-release v0.13.0 with this change? because we have the voter tutorial, and there is a good chance that users will run into trouble with it.

@ilgooz ilgooz merged commit 1dfbb4f into develop Dec 23, 2020
@ilgooz ilgooz deleted the fix/v branch December 23, 2020 18:38
faddat added a commit to faddat/starport that referenced this pull request Jan 7, 2021
@faddat
Merge https://github.com/tendermint/starport into sos-lite
12c1573 
# By vms (85) and others
# Via GitHub (23) and others
* https://github.com/tendermint/starport: (276 commits)
  refactor: use a fixed-name dir for Starport Network chain sources (ignite#597)
  Update devices.yml (ignite#616)
  refactor: set chaincmd commands as version agnostic (ignite#614)
  feature(network): show errors from appd binary (ignite#506)
  refactor: use stable version of Starport in docs (ignite#610)
  refactor: package for blockchain application commands (ignite#583)
  refactor: cleanup home files (ignite#595)
  feat(pkg/gomodulepath): add tests for paths with versions
  docs: install.md (ignite#602)
  fix: semantic-pr
  fix: determining version number in go paths (ignite#598)
  docs: update readme with a link to v0.13 video (ignite#593)
  diable snapcraft
  ap get update
  fix: changelog small fix (ignite#588)
  Update changelog.md (ignite#587)
  feat(network): disable create command for Launchpad apps (ignite#586)
  refactor(docs): change 'pulling blockchain' to 'fetching source code' (ignite#585)
  Update version of tendermint/vue (ignite#582)
  fix: integration tests (ignite#581)
  ...

# Conflicts:
#	.github/workflows/pi-image.yml
#	.pi/starport.json
#	go.mod
#	go.sum
#	starport/templates/app/launchpad/.github/workflows/build.yml.plush
#	starport/templates/app/launchpad/.github/workflows/pi.yml.plush
#	starport/templates/app/launchpad/.pi/image.bash.plush
#	starport/templates/app/launchpad/.pi/pibuild.json.plush
#	starport/templates/app/launchpad/.pi/{{appName}}d.service.plush
#	starport/ui/package-lock.json
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
fix: determining version number in go paths (ignite#598)
4fd3c03 
fixes ignite#596.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@lumtis lumtis Awaiting requested review from lumtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: app cmd creates a blockchain with a wrong name on v0.13
2 participants
@ilgooz @fadeev