Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web scaffold working on Gitpod #582

Merged
merged 1 commit into from
Dec 21, 2020
Merged

fix: web scaffold working on Gitpod #582

merged 1 commit into from
Dec 21, 2020

Conversation

fadeev
Copy link
Contributor

@fadeev fadeev commented Dec 20, 2020

On the current version of @tendermint/vue web scaffold doesn't work on Gitpod, because API URL is not properly constructed. This fixes the problem.

@fadeev fadeev requested review from ilgooz and lumtis as code owners December 20, 2020 19:32
@ilgooz ilgooz merged commit d007b53 into develop Dec 21, 2020
@ilgooz ilgooz deleted the fix-web-scaffold branch December 21, 2020 05:46
faddat added a commit to faddat/starport that referenced this pull request Jan 7, 2021
# By vms (85) and others
# Via GitHub (23) and others
* https://github.com/tendermint/starport: (276 commits)
  refactor: use a fixed-name dir for Starport Network chain sources (ignite#597)
  Update devices.yml (ignite#616)
  refactor: set chaincmd commands as version agnostic (ignite#614)
  feature(network): show errors from appd binary (ignite#506)
  refactor: use stable version of Starport in docs (ignite#610)
  refactor: package for blockchain application commands (ignite#583)
  refactor: cleanup home files (ignite#595)
  feat(pkg/gomodulepath): add tests for paths with versions
  docs: install.md (ignite#602)
  fix: semantic-pr
  fix: determining version number in go paths (ignite#598)
  docs: update readme with a link to v0.13 video (ignite#593)
  diable snapcraft
  ap get update
  fix: changelog small fix (ignite#588)
  Update changelog.md (ignite#587)
  feat(network): disable create command for Launchpad apps (ignite#586)
  refactor(docs): change 'pulling blockchain' to 'fetching source code' (ignite#585)
  Update version of tendermint/vue (ignite#582)
  fix: integration tests (ignite#581)
  ...

# Conflicts:
#	.github/workflows/pi-image.yml
#	.pi/starport.json
#	go.mod
#	go.sum
#	starport/templates/app/launchpad/.github/workflows/build.yml.plush
#	starport/templates/app/launchpad/.github/workflows/pi.yml.plush
#	starport/templates/app/launchpad/.pi/image.bash.plush
#	starport/templates/app/launchpad/.pi/pibuild.json.plush
#	starport/templates/app/launchpad/.pi/{{appName}}d.service.plush
#	starport/ui/package-lock.json
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants