Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): add faucet fee config (backport #4513) #4514

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 17, 2025

Allow to specify fee to be paid by the faucet in the config.
An user on discord had the issue that when the chains is requiring the fee, the faucet will fail.
This was already supported, but we didn't have a field to pass in the config for it.


This is an automatic backport of pull request #4513 done by Mergify.

* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix

(cherry picked from commit 4abea76)

# Conflicts:
#	ignite/config/chain/base/config.go
Copy link
Contributor Author

mergify bot commented Feb 17, 2025

Cherry-pick of 4abea76 has failed:

On branch mergify/bp/release/v28.x.y/pr-4513
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 4abea764.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/test-cov.yml
	modified:   .github/workflows/test-integration.yml
	modified:   .github/workflows/test.yml
	modified:   changelog.md
	modified:   ignite/services/chain/faucet.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/config/chain/base/config.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Feb 17, 2025
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. type:internal labels Feb 17, 2025
@julienrbrt julienrbrt merged commit e049a22 into release/v28.x.y Feb 17, 2025
40 of 44 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4513 branch February 17, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs type:internal type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant