Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services): add faucet fee config #4513

Merged
merged 4 commits into from
Feb 17, 2025
Merged

feat(services): add faucet fee config #4513

merged 4 commits into from
Feb 17, 2025

Conversation

julienrbrt
Copy link
Member

Allow to specify fee to be paid by the faucet in the config.
An user on discord had the issue that when the chains is requiring the fee, the faucet will fail.
This was already supported, but we didn't have a field to pass in the config for it.

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Feb 17, 2025
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. type:internal labels Feb 17, 2025
ilgooz
ilgooz previously approved these changes Feb 17, 2025
View reviewed changes
@julienrbrt julienrbrt merged commit 4abea76 into main Feb 17, 2025
41 of 44 checks passed
@julienrbrt julienrbrt deleted the julien/faucet-fee branch February 17, 2025 16:59
mergify bot pushed a commit that referenced this pull request Feb 17, 2025
@julienrbrt @mergify
feat(services): add faucet fee config (#4513)
54f07a5 
* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix

(cherry picked from commit 4abea76)

# Conflicts:
#	ignite/config/chain/base/config.go
@mergify mergify bot mentioned this pull request Feb 17, 2025
Merged
julienrbrt added a commit that referenced this pull request Feb 17, 2025
@mergify @julienrbrt
feat(services): add faucet fee config (backport #4513) (#4514)
e049a22 
* feat(services): add faucet fee config (#4513)

* feat(services): add faucet fee config

* cl

* pin 1.23 to ci (ref #4509)

* fix

(cherry picked from commit 4abea76)

# Conflicts:
#	ignite/config/chain/base/config.go

* conflict

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
@BrewTestBot BrewTestBot mentioned this pull request Feb 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz left review comments

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@julienrbrt julienrbrt

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @ilgooz