-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add EsgfQuery
class to wrap ESGF search RESTful APIs
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[feat] Add `EsgfQuery` class [feat] Complete `EsgfQuery` class [feat] Complete `EsgfQuery` class
Closed
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 99.82% 99.80% -0.03%
==========================================
Files 7 8 +1
Lines 1678 2005 +327
==========================================
+ Hits 1675 2001 +326
- Misses 3 4 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
utils:URLencode()
#62esgf_query()
to enable a step-by-step query builder #63offset
for query result pagination #65This is a big PR with a lot of refactorings and new features.
EPWSHIFTR_ENV
tothis
.EsgfQuery
has been added to wrap the ESGF search RESTful APIs in a more flexible way. This allows to build a query in a step by step, e.g.query_esgf()$project("CMIP6")$activity_id("ScenarioMIP")$experiment_id(!"ssp126")$collect()
. This solves Refactoresgf_query()
to enable a step-by-step query builder #63 and Useoffset
for query result pagination #65.EsgfQuery$new()
should beesgf_query()
. Unfortunately, this name has been taken.esgf_query()
has also utilized the new query URL encoding function. This solves Useutils:URLencode()
#62. Note thatutils::URLencode()
is not used, since it also encodes other characters like!
,+
, etc.