Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utils:URLencode() #62

Closed
hongyuanjia opened this issue Sep 19, 2022 · 0 comments · Fixed by #73
Closed

Use utils:URLencode() #62

hongyuanjia opened this issue Sep 19, 2022 · 0 comments · Fixed by #73
Assignees
@hongyuanjia
Labels
enhancement New feature or request
Milestone
v0.1.4

Comments

@hongyuanjia
Copy link
Member

esgf_query() uses a self-implemented URL encode approach, which is kind of a hack. It is better to take advantage of the utils::URLencode() function instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongyuanjia hongyuanjia

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.4
Development

Successfully merging a pull request may close this issue.

[feat] Add EsgfQuery class to wrap ESGF search RESTful APIs ideas-lab-nus/epwshiftr
1 participant
@hongyuanjia