Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes from this!=NULL removal #56

Merged
merged 2 commits into from
Jul 3, 2016

Conversation

DanielGibson
Copy link

@DanielGibson DanielGibson commented Jun 6, 2016

mostly checks before calling AddReference()/RemReference() so far.

this should fix #55

I haven't experienced any further crashes, but I only started the first level and played 2 minutes, so there may be more.

mostly checks before calling AddReference()/RemReference()
@DanielGibson DanielGibson changed the title Game can be executed and quit without crashes Fix crashes from this!=NULL removal Jun 6, 2016
@DanielGibson
Copy link
Author

and now I've also added a fix for the ModExt.txt vs ModEXT.txt problem.

@DanielGibson
Copy link
Author

@rcgordon As the game segfaults at startup without these changes, can you merge this?

@icculus
Copy link
Owner

icculus commented Jul 3, 2016

Sorry, I was busy elsewhere and not paying attention. Merging now!!

@icculus icculus merged commit 570f166 into icculus:master Jul 3, 2016
@DanielGibson
Copy link
Author

Thanks a lot! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this can be NULL - segmentation fault
2 participants