Fix ModEXT.txt issues #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not work on Mac and Windows, and git unable to deal with file thrashing with another file of similar name.
Some file systems are case-sensitive, so use proper casing.
|
I think this makes sense. 👍 |
|
Anything wrong with the PR? |
Nope, sorry for the delay! --ryan. |
|
hmm I just noticed that in my serious sam installation, the file actually seems to be called ModExt.txt, not ModEXT.txt. |
|
ok, supporting both wasn't that hard after all, added a fix to #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a ModExt.txt symlink to ModEXT.txt is a bad idea for filesystems that does not support files having the same name with different casing. symlink is also not compatible with Windows anyway.
Instead the root of the problem is fixed by modifying the code to load the correct file.