-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue465 multizone office simple hydronic #469
Issue465 multizone office simple hydronic #469
Conversation
…ipt will not work)
Great to see this. Thanks @icupeiro! |
…m:icupeiro/project1-boptest into issue465_multizone_office_simple_hydronic
…465_multizone_office_simple_hydronic
Seems that I forgot a few commits from master into my branch, which changed the makefile to a more generic script |
…465_multizone_office_simple_hydronic
@dhblum just a gentle reminder to have a look/merge this issue! |
Thanks a lot @icupeiro. I'm aiming to review in the coming week. |
@icupeiro I'm reviewing. Ok if I push some changes to your fork? So far, unit test related. |
Sure! No problem |
build failed due to typo
@dhblum reminder. It would be nice if this gets merged before I depart |
@icupeiro At our last IBPSA BOPTEST progress meeting I discussed with @saroele a concern I have about merging without an open-source compiler option available to continue maintenance and testing afterwards. We discussed doing additional testing with OpenModelica to see if it can compile an FMU that can be simulated in BOPTEST, and if not what the issues are. |
@dhblum the model compiles with OM, I just had troubles finding the target platform option in OM and I moved forward with OCT. But compilation of the FMU should be fine. |
@icupeiro That's good it complies in OM. I would like the whole workflow to be tested though, including simulation of the resulting FMU in BOPTEST to identify any remaining issues. |
Multiply power output by -1 as here output is Q to obtain the KPIs correctly for cost we need to multiply by -1
…ydronic fix steerability fcu airside and heating cooling coil ahu
To-do:
|
…to issue465_multizone_office_simple_hydronic
…ed conditional input connector
Closing and replacing by #618. |
This tackles #465
Pending to-do:
@dhblum @JavierArroyoBastida FYI. You should be able now to toy around with the model and run the tests
I will ask Lieve to allocate time for the next IBPSA meeting to present the model.
Note that in the makefile I did not include the compilation step in the tests due to the incompatibility with MSL4.0.0. This step is done manually using OCT at the moment