Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue465 multizone office simple hydronic #469

Closed

Conversation

icupeiro
Copy link
Contributor

@icupeiro icupeiro commented Aug 8, 2022

This tackles #465

Pending to-do:

  • Discuss model in next IBPSA meeting (fan/pump powers, control, humidity, etc...)
  • Write documentation

@dhblum @JavierArroyoBastida FYI. You should be able now to toy around with the model and run the tests

I will ask Lieve to allocate time for the next IBPSA meeting to present the model.

Note that in the makefile I did not include the compilation step in the tests due to the incompatibility with MSL4.0.0. This step is done manually using OCT at the moment

@javiarrobas
Copy link
Contributor

Great to see this. Thanks @icupeiro!

@icupeiro
Copy link
Contributor Author

icupeiro commented Aug 9, 2022

Seems that I forgot a few commits from master into my branch, which changed the makefile to a more generic script
Note that, consequently, the tests will fail since the model cannot compile.
I had to run them in my own machine after deploying the testcase.

@icupeiro
Copy link
Contributor Author

icupeiro commented Oct 4, 2022

@dhblum just a gentle reminder to have a look/merge this issue!

@dhblum
Copy link
Collaborator

dhblum commented Oct 4, 2022

Thanks a lot @icupeiro. I'm aiming to review in the coming week.

@dhblum
Copy link
Collaborator

dhblum commented Oct 7, 2022

@icupeiro I'm reviewing. Ok if I push some changes to your fork? So far, unit test related.

@icupeiro
Copy link
Contributor Author

icupeiro commented Oct 7, 2022

Sure! No problem

build failed due to typo
@icupeiro
Copy link
Contributor Author

@dhblum reminder. It would be nice if this gets merged before I depart

@dhblum
Copy link
Collaborator

dhblum commented Oct 25, 2022

@icupeiro At our last IBPSA BOPTEST progress meeting I discussed with @saroele a concern I have about merging without an open-source compiler option available to continue maintenance and testing afterwards. We discussed doing additional testing with OpenModelica to see if it can compile an FMU that can be simulated in BOPTEST, and if not what the issues are.

@icupeiro
Copy link
Contributor Author

@dhblum the model compiles with OM, I just had troubles finding the target platform option in OM and I moved forward with OCT. But compilation of the FMU should be fine.

@dhblum
Copy link
Collaborator

dhblum commented Oct 25, 2022

@icupeiro That's good it complies in OM. I would like the whole workflow to be tested though, including simulation of the resulting FMU in BOPTEST to identify any remaining issues.

bmerema and others added 4 commits December 5, 2022 17:48
Multiply power output by -1 as here output is Q to obtain the KPIs correctly for cost we need to multiply by -1
…ydronic

fix steerability fcu airside and heating cooling coil ahu
@icupeiro
Copy link
Contributor Author

icupeiro commented Nov 14, 2023

To-do:

  • Modify heat producer to convert it to an ASHP
  • Update to latest IDEAS
  • Merge BOPTEST master branch
  • Compile the model with OCT
  • Run BOPTEST tests

@dhblum
Copy link
Collaborator

dhblum commented Feb 8, 2024

Closing and replacing by #618.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants