add snapping to floating windows #8088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f26ef3 to
f59c049
Compare
63a2149 to
c6597a0
Compare
Works for both moving and resizing of windows. It comes with 3 options: `general:snap:enabled` - whether it's enabled, off by default `general:snap:window_gap` - minimum gap in pixels between windows before snapping. Setting to 0 effectively turns off this method of snapping. `general:snap:monitor_gap` - minimum gap in pixels between window and monitor edges before snapping. Again, setting it to 0 effectively turns it off.
The approach of performing corner snaps after each individual edge snap results in far fewer scenarios where snapping can occur. After trying it out for a while, I found that I prefer an approach that's more prone to snapping.
|
tag me for review when ready |
|
@vaxerski ready for review. EDIT: Sorry, one more change incoming. I've been working under the assumption that all windows share the same border size |
vaxerski
reviewed
Oct 18, 2024
- add new line between functions - use std::function typedef for SnapFn and make snap functions static - avoid uninitialized variable declarations. - change ignore condition m_bIsX11 to isX11OverrideRedirect() - use braces for CBox and Vector2D declarations. - add SNAP_INVALID to eSnapEdge enum - use bitshift notation for eSnapEdge and eRectCorner - make performSnap a non-member function.
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
While moving and resizing floating windows, edges and corners will snap to the edges/corners of the monitor or other windows when they get close enough to each other.
It started as an update to @shadowmax31 's PR #3236 , but was eventually changed to behave more similarly to KWin's snapping feature.
It comes with 3 options:
general:snap:enabled- whether it's enabled, off by defaultgeneral:snap:window_gap- minimum gap in pixels between windows before snapping. Setting to 0 effectively turns off this method of snapping.general:snap:monitor_gap- minimum gap in pixels between window and monitor edges before snapping. Again, setting it to 0 effectively turns it off.Here's a video of it with these settings:
general:snap { enabled = true window_gap = 25 # pixels monitor_gap = 10 # pixels }2024-10-11.18-28-50.mp4
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Not that I can think of.
Is it ready for merging, or does it need work?
Ready to merge.