Add snapping to floating windows #3236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows can snap to monitor or other windows. Currently, the left side is checked against the left side only (same for the all sides).
Otherwise snapping does not working in some cases on window overlap
This could be added to allow snapping outside of a window, but it feels
a bit weird / buggy depending on the gap size. So, I'll leave it out for
now.
```
else if (isInRangeForSnapping(maxSide, boundingMinSide, snap)) {
newPosition = boundingMinSide - size;
}
else if (isInRangeForSnapping(minSide, boundingMaxSide, snap)) {
newPosition = boundingMaxSide;
}
```
This is off by default because it can be weird depending on snapping strength and gap size
Oglo12
approved these changes
Sep 13, 2023
|
request my review when ready |
|
@shadowmax31 Why did you close the snapping windows PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Adds a floating window snapping option: #3230
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
It adds 3 configuration options:
Is it ready for merging, or does it need work?
Ready