Use mount/unmountAll from @hypothesis/frontend-testing
#6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unmount components mounted via `mount` from `@hypothesis/frontend-testing` after each test has run.
Replace calls to `mount` from enzyme with `mount` from @hypothesis/frontend-testing. This reduces the boilerplate for creating DOM containers and unmounting components.
acelaya
approved these changes
Nov 27, 2024
| @@ -7,6 +8,9 @@ sinon.assert.expose(assert, { prefix: null }); | |||
|
|
|||
| // Configure Enzyme for UI tests. | |||
| configure({ adapter: new Adapter() }); | |||
| afterEach(() => { | |||
| unmountAll(); | |||
| }); | |||
There was a problem hiding this comment.
Not sure if we have a tests bootstrap/init/set-up script in other projects, but if we do, we should do this in all of them, so that we don't have to remember unmounting every time.
There was a problem hiding this comment.
I believe we have a bootstrap.js file in every project to set up Sinon, asserts, the Enzyme adapter etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as hypothesis/client#6693, but for this project.