Use mount/unmountAll from @hypothesis/frontend-testing
#6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `mount` utility from @hypothesis/frontend-testing for most tests instead of `mount` from Enzyme. This simplifies test cleanup as the `unmountAll` call in boostrap.js will unmount any UI components mounted via the function from @hypothesis/frontend-testing. There are a couple of exceptions for tests which need to modify or reuse the container for other purposes. These still use Enzyme's `mount` API directly.
6d00414 to
08cda4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6693 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 271 271
Lines 10214 10214
Branches 2433 2433
=======================================
Hits 10156 10156
Misses 58 58 ☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the client to use the new
mount/unmountAllfunctions from @hypothesis/frontend-testing to simplify cleanup after tests run. This follows the same pattern as hypothesis/h#9125.