-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the direct-link CTA for third party accounts #658
Conversation
The CTA message shown when an anonymous user visits a direct link contains links to the Hypothesis site and makes other assumptions, such as the user being able to create accounts and those accounts being free, which may not be applicable on sites that use third party accounts. For now, just hide this CTA if the page uses third party accounts. Fixes #656 Fixes #657
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 91.02% 91.03% +<.01%
==========================================
Files 135 135
Lines 5394 5397 +3
Branches 933 934 +1
==========================================
+ Hits 4910 4913 +3
Misses 484 484
Continue to review full report at Codecov.
|
🙏 |
As we did with another similar banner in the sidebar (Slack discussion, GitHub issue 1, GitHub issue 2) I wonder if we can just remove this banner from the product entirely?
As a general rule maybe the UI shouldn't be peppered with additional messages telling users to sign up or log in. @dawariley ? |
I've spoken to @seanh about this issue and agreed that we shouldn't surface non applicable messaging to users in the UI, such as in the eLife scenario. However before disabling this CTA to login we need to determine what scenarios this message is displayed in. I would also add that if there is an additional way to sign in/login provided on the top bar (which according to the screenshot appears to be the case) then it becomes less critical to show this message unless the goal is: to drive H signups or we are concerned that users will miss the login/signup links at the top. Trying to understand what the original rationale was for having this additional messaging display in the first place. Perhaps @dwhly can shed some light on this. |
It looks to me as if this notice appears:
|
👍 Tested that the footer still shows in first-party context but no longer shows on publisher test site |
LGTM |
The CTA message shown when an anonymous user visits a direct link
contains links to the Hypothesis site and makes other assumptions, such
as the user being able to create accounts and those accounts being free,
which may not be applicable on sites that use third party accounts.
For now, just hide this CTA if the page uses third party accounts.
Fixes #656
Fixes #657
Example of inappropriate message with current released client: