Remove create account banner #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text is potentially inappropriate in the context of publisher-managed accounts where the account might not be free and the user might not be able to create one themselves. In the first party account context we agreed that the banner is a bit redundant anyway. See https://hypothes-is.slack.com/archives/C07NXBDNW/p1510080494000386
The template no longer uses this property.
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
- Coverage 90.98% 90.98% -0.01%
==========================================
Files 135 135
Lines 5368 5367 -1
Branches 930 930
==========================================
- Hits 4884 4883 -1
Misses 484 484
Continue to review full report at Codecov.
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text is potentially inappropriate in the context of publisher-managed accounts where the account might not be free and the user might not be able to create one themselves.
In the first party account context we agreed that the banner is a bit redundant anyway. See https://hypothes-is.slack.com/archives/C07NXBDNW/p1510080494000386